[Asterisk-code-review] release summary.py: Import referenced function and allow a r... (repotools[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/8378 )

Change subject: release_summary.py: Import referenced function and allow a remote_url
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8378/1/release_summary.py
File release_summary.py:

https://gerrit.asterisk.org/#/c/8378/1/release_summary.py@715
PS1, Line 715:     summary = ReleaseSummary(release_options, jira=jira, debug=True)
> I take it ReleaseSummary() already knew about release_options.remote_url an
Correct. Both this and and 'get_repo' call were already in the module, but were unreferenced. It worked fine when called from another module like mkrelease, but called from the command line it would break.



-- 
To view, visit https://gerrit.asterisk.org/8378
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I041bcb26c9ef2382879e1b8c39f2e99b6725ba68
Gerrit-Change-Number: 8378
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 15:39:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180223/beefe833/attachment.html>