[Asterisk-code-review] Deprecate legacy modules. (asterisk[master])

Jenkins2 asteriskteam at digium.com
Mon Feb 19 06:59:01 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8197 )

Change subject: Deprecate legacy modules.
......................................................................

Deprecate legacy modules.

* app_fax (replaced by res_fax).
* res_config_sqlite (replaced by res_config_sqlite3).
* res_monitor (replaced by app_mixmonitor).

This is related to ASTERISK~23657 but does not resolve that ticket.
Resolving that ticket would require complete removal of res_monitor.

ASTERISK-27671 #close

Change-Id: I16a3edd61fc1abd4a7b2e9357693ed663f62dd49
---
M CHANGES
M UPGRADE.txt
M apps/app_fax.c
M res/res_config_sqlite.c
M res/res_monitor.c
5 files changed, 32 insertions(+), 3 deletions(-)

Approvals:
  Matthew Fredrickson: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/CHANGES b/CHANGES
index cd7e75e..ba153bc 100644
--- a/CHANGES
+++ b/CHANGES
@@ -12,6 +12,11 @@
 --- Functionality changes from Asterisk 15 to Asterisk 16 --------------------
 ------------------------------------------------------------------------------
 
+app_fax
+------------------
+ * The app_fax module is now deprecated, users should migrate to the
+   replacement module res_fax.
+
 app_macro
 ------------------
  * The app_macro module is now deprecated and by default it is no longer
@@ -43,6 +48,16 @@
    When set the wrapuptime on the member is used instead of the wrapuptime
    defined for the queue itself.
 
+res_config_sqlite
+------------------
+ * The res_config_sqlite module is now deprecated, users should migrate to the
+   replacement module res_config_sqlite3.
+
+res_monitor
+------------------
+ * The res_monitor module is now deprecated, users should migrate to the
+   replacement module app_mixmonitor.
+
 res_pjsip
 ------------------
  * A new AMI action, PJSIPShowAors, has been added which displays information
diff --git a/UPGRADE.txt b/UPGRADE.txt
index d398e5f..3668258 100644
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -26,6 +26,10 @@
 
 New in 16.0.0:
 
+app_fax:
+ - The app_fax module is now deprecated, users should migrate to the
+   replacement module res_fax.
+
 app_macro:
  - The app_macro module is now deprecated and by default it is no longer
    built.  Users should migrate to app_stack (Gosub).  A warning is logged
@@ -44,6 +48,14 @@
  - The cdr_syslog module is now deprecated and by default it is no longer
    built.
 
+res_config_sqlite:
+ - The res_config_sqlite module is now deprecated, users should migrate to the
+   replacement module res_config_sqlite3.
+
+res_monitor:
+ - The res_monitor module is now deprecated, users should migrate to the
+   replacement module app_mixmonitor.
+
 Core:
  - libedit is no longer available as an embedded library and must be provided
    by the system.
diff --git a/apps/app_fax.c b/apps/app_fax.c
index 540e8e3..293925a 100644
--- a/apps/app_fax.c
+++ b/apps/app_fax.c
@@ -16,7 +16,8 @@
 	<defaultenabled>no</defaultenabled>
 	<depend>spandsp</depend>
 	<conflict>res_fax</conflict>
-	<support_level>extended</support_level>
+	<support_level>deprecated</support_level>
+	<replacement>res_fax</replacement>
 ***/
 
 #include "asterisk.h"
diff --git a/res/res_config_sqlite.c b/res/res_config_sqlite.c
index 5ca623c..83d2dca 100644
--- a/res/res_config_sqlite.c
+++ b/res/res_config_sqlite.c
@@ -82,7 +82,7 @@
 
 /*** MODULEINFO
 	<depend>sqlite</depend>
-	<support_level>extended</support_level>
+	<support_level>deprecated</support_level>
  ***/
 
 #include "asterisk.h"
diff --git a/res/res_monitor.c b/res/res_monitor.c
index a8631dc..95acf55 100644
--- a/res/res_monitor.c
+++ b/res/res_monitor.c
@@ -25,7 +25,8 @@
 
 /*** MODULEINFO
 	<use type="module">func_periodic_hook</use>
-	<support_level>core</support_level>
+	<support_level>deprecated</support_level>
+	<replacement>app_mixmonitor</replacement>
  ***/
 
 #include "asterisk.h"

-- 
To view, visit https://gerrit.asterisk.org/8197
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16a3edd61fc1abd4a7b2e9357693ed663f62dd49
Gerrit-Change-Number: 8197
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180219/27b0ba02/attachment.html>


More information about the asterisk-code-review mailing list