[Asterisk-code-review] res pjsip: Use pjsip sip uri.user param instead of other param (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8210 )

Change subject: res_pjsip: Use pjsip_sip_uri.user_param instead of other_param
......................................................................


Patch Set 1:

> > > I think this has the added benefit of not getting the user=
 > > > parameter added twice to the URI when the message is printed. 
 > I
 > > > think there might have been a reported issue about it.
 > >
 > > Yep it was ASTERISK-26988 which was fixed awhile ago.  This patch
 > > removes that change to just set the single user parameter
 > position
 > > even if it already has a value.
 > 
 > So this is a behavior change. Should we only set it if it’s not
 > currently set?

I think the code as-is is fine.  I was thinking that there was a reported
issue that this patch should reference as fixing.

If there was a value already set then it would be because we already
called this function.  A quick search shows we don't set the user parameter
value to anything else.  Since there is only one user parameter value string
there is no possibility of duplicating it and reintroducing ASTERISK-26988.


-- 
To view, visit https://gerrit.asterisk.org/8210
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a0ce8a60ecee27489735bf56fd707719d8c2ed6
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sat, 17 Feb 2018 20:30:30 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180217/0639abc1/attachment.html>