[Asterisk-code-review] BuildSystem: Allow newer autotools on OpenBSD. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8235 )

Change subject: BuildSystem: Allow newer autotools on OpenBSD.
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Feel free to address my comment about the -z check or not, it makes no difference right now.

Keep in mind I'm only reviewing this for shell script correctness, I assume you've tested that this actually does what you expect.

https://gerrit.asterisk.org/#/c/8235/1/bootstrap.sh
File bootstrap.sh:

https://gerrit.asterisk.org/#/c/8235/1/bootstrap.sh@1
PS1, Line 1: #!/bin/sh
Not a new issue but is '[' a valid alias for 'test' outside of bash?


https://gerrit.asterisk.org/#/c/8235/1/bootstrap.sh@22
PS1, Line 22: 		[ -z "$AUTOCONF_VERSION" ] && export AUTOCONF_VERSION=2.63
If we ever change the first line to '#!/bin/sh -e' this would error out if $AUTOCONF_VERSION is set non-blank.  Same applies to next line as well.

This will work as is, but it would be less fragile if you used:
[ -n "$AUTOCONF_VERSION" ] || export AUTOCONF_VERSION=2.63



-- 
To view, visit https://gerrit.asterisk.org/8235
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec9dafbb0c16b6f2740c641980bc2eaaf995624
Gerrit-Change-Number: 8235
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sat, 17 Feb 2018 00:11:03 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180216/f14ff1c4/attachment.html>