[Asterisk-code-review] bridge roles: Use a non-locking linked list where appropriate (asterisk[13])

[Sean Bright]

Sean Bright has uploaded this change for review. ( https://gerrit.asterisk.org/8216


Change subject: bridge_roles: Use a non-locking linked list where appropriate
......................................................................

bridge_roles: Use a non-locking linked list where appropriate

Also explicitly initialize with the AST_LIST_HEAD_NOLOCK_INIT macro for
clarity.

Change-Id: I4bc39ec33bc3ff77e1a971a01ace87deb965be3f
---
M main/bridge_roles.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/16/8216/1

diff --git a/main/bridge_roles.c b/main/bridge_roles.c
index 1d781ca..d68e6b1 100644
--- a/main/bridge_roles.c
+++ b/main/bridge_roles.c
@@ -53,12 +53,12 @@
 
 struct bridge_role {
 	AST_LIST_ENTRY(bridge_role) list;
-	AST_LIST_HEAD(, bridge_role_option) options;
+	AST_LIST_HEAD_NOLOCK(, bridge_role_option) options;
 	char role[AST_ROLE_LEN];
 };
 
 struct bridge_roles_datastore {
-	AST_LIST_HEAD(, bridge_role) role_list;
+	AST_LIST_HEAD_NOLOCK(, bridge_role) role_list;
 };
 
 /*!
@@ -129,6 +129,8 @@
 		ast_datastore_free(datastore);
 		return NULL;
 	}
+
+	AST_LIST_HEAD_INIT_NOLOCK(&roles_datastore->role_list);
 
 	datastore->data = roles_datastore;
 	ast_channel_datastore_add(chan, datastore);
@@ -266,6 +268,8 @@
 		return -1;
 	}
 
+	AST_LIST_HEAD_INIT_NOLOCK(&role->options);
+
 	ast_copy_string(role->role, role_name, sizeof(role->role));
 
 	AST_LIST_INSERT_TAIL(&roles_datastore->role_list, role, list);

-- 
To view, visit https://gerrit.asterisk.org/8216
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bc39ec33bc3ff77e1a971a01ace87deb965be3f
Gerrit-Change-Number: 8216
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180215/108177c8/attachment-0001.html>