[Asterisk-code-review] BuildSystem: Invoke ldconfig with previous path. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7999 )

Change subject: BuildSystem: Invoke ldconfig with previous path.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/7999/2/Makefile
File Makefile:

https://gerrit.asterisk.org/#/c/7999/2/Makefile@974
PS2, Line 974: ifneq ($(LDCONFIG),)
Technically this is incorrect (as with the similar check for install).  It will equal ':' if ldconfig is not installed.  That's another issue I'm not sure if it's even possible for ldconfig to not be available.

I'm inclined to say the fix would be to remove the Makefile checks for LDCONFIG missing.  If it is the ':' will cause the command to be ignored.



-- 
To view, visit https://gerrit.asterisk.org/7999
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa2c0b5e07119d1a556f8ff6349eaf09e986888
Gerrit-Change-Number: 7999
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 14 Feb 2018 19:31:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180214/d21cece2/attachment.html>