[Asterisk-code-review] BuildSystem: Do not warn when bash is not installed. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8076 )

Change subject: BuildSystem: Do not warn when bash is not installed.
......................................................................


Patch Set 2:

> I'd prefer that we use `ifneq ($(BASH),)` to skip running the
 > command when appropriate (I assume this would solve the problem). 
 > If bash is installed we don't want to suppress errors from the
 > command.

Did you have a chance to actually test this on the system without bash?  Looking at the configure script I'm concerned that my first comment was incorrect and we should test `ifneq ($(BASH),:)`, it looks like the configure script sets BASH=: when it's not found.


-- 
To view, visit https://gerrit.asterisk.org/8076
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdf268b0b98c3e7d8089ba87cf78136ac1d785b
Gerrit-Change-Number: 8076
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 12 Feb 2018 07:58:44 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180212/f5405b39/attachment-0001.html>