[Asterisk-code-review] pjsip: Rewrite OPTIONS support with new eyes. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7710 )

Change subject: pjsip: Rewrite OPTIONS support with new eyes.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Since this might change other things I figured I'd get this one out of the way before commenting further.

https://gerrit.asterisk.org/#/c/7710/2/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/#/c/7710/2/res/res_pjsip/pjsip_options.c@2217
PS2, Line 2217: 	sched = ast_sched_context_create();
              : 	if (!sched) {
              : 		ast_res_pjsip_cleanup_options_handling();
              : 		return -1;
              : 	}
              : 
              : 	if (ast_sched_start_thread(sched)) {
              : 		ast_res_pjsip_cleanup_options_handling();
              : 		return -1;
              : 	}
Use the ast_sip_sched scheduler instead of the generic one.  It has support for serializers and operations by "name" which might eliminate a container of your own.



-- 
To view, visit https://gerrit.asterisk.org/7710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a5ebbfca9001dfe933eaeac4d3babd8d2e6f082
Gerrit-Change-Number: 7710
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 15:25:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180207/b2a48424/attachment.html>