[Asterisk-code-review] manager: Add AMI event Load/Unload (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8166 )

Change subject: manager: Add AMI event Load/Unload
......................................................................


Patch Set 1:

> > > > I don't see much use for these Load/Unload events.  The
 > > majority
 > > > of
 > > > > the events would happen when nobody can be connected to AMI
 > so
 > > > > nobody would see the events.
 > > >
 > > > Hi Richard,
 > > >
 > > > This ami event is not only for the manager module, but also all
 > > > other modules.
 > > >
 > > > It designed for send load/unload notify of the all the modules.
 > > For
 > > > example, when the app_queue.so module was loaded/unloaded, the
 > > > Asterisk sends this ami event. Just like an Reload ami event.
 > >
 > > That's my point.  You cannot be connected to AMI before the
 > modules
 > > are loaded when asterisk starts so you could not see the events.
 > > On asterisk shutdown, you would be disconnected from AMI and
 > would
 > > not see the unload events.  You would only be able to see these
 > > events if you manually loaded/unloaded modules.
 > 
 > A-ha, now I've got it.
 > 
 > Yes, you're right. It those of cases, not many user can see the
 > messages. And for the manual load/unload commands will fire this
 > events.
 > 
 > But, that's why I designed this event.
 > 
 > If the some program which connected to the Asterisk via AMI
 > connection, there's no way to recognizing when the module has been
 > loaded/unloaded if the administrator typed "module load/unload
 > <modulename>" command.

Do you have a need for this?

It seems so unnecessary for a program to track manually loading/unloading modules.  Having to manually load/unload modules is an exception condition.  If a program were going to load/unload modules it would use the AMI ModuleLoad action which already reports the status of the action in the response.


-- 
To view, visit https://gerrit.asterisk.org/8166
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib916c41eddd63651952998f2f49c57c42ef87a64
Gerrit-Change-Number: 8166
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 21:24:19 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180206/e4733625/attachment-0001.html>