[Asterisk-code-review] res pjsip/config domain aliases.c: Add check for missing dom... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8159 )

Change subject: res_pjsip/config_domain_aliases.c: Add check for missing domain.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c
File res/res_pjsip/config_domain_aliases.c:

https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c@64
PS1, Line 64: 		return -1;
> Sure, but aren't you making Asterisk fail where it previously didn't even p
Fine.  I've removed the return -1 line.

I still think it is wrong to allow this invalid configuration to exist.  It allows the user to think their setup is working when it isn't.



-- 
To view, visit https://gerrit.asterisk.org/8159
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be
Gerrit-Change-Number: 8159
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 05 Feb 2018 20:05:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180205/300dd3e0/attachment.html>