[Asterisk-code-review] app confbridge: ConfbridgeList event has standard channel sh... (asterisk[15])

Richard Mudgett asteriskteam at digium.com
Mon Feb 5 12:54:29 CST 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8139 )

Change subject: app_confbridge: ConfbridgeList event has standard channel shapshot headers.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8139/1/CHANGES
File CHANGES:

https://gerrit.asterisk.org/#/c/8139/1/CHANGES@31
PS1, Line 31:    CallerIDName is now output as "<unknown>" instead of "<no name>".
> Won't this potentially break people's AMI parsers if they are checking for 
We are saying the same thing.  It is such a minor thing that it doesn't really matter.

Actually, if someone is sensitive to this then they really have set themselves up for failure.  What prevents someone from calling in with their Caller-ID name set to "<no name>"?



-- 
To view, visit https://gerrit.asterisk.org/8139
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf7d54a9d40194c2db060bc9b4979fab6720d977
Gerrit-Change-Number: 8139
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 05 Feb 2018 18:54:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180205/96c7ac16/attachment.html>


More information about the asterisk-code-review mailing list