[Asterisk-code-review] endpoint identifiers: Some code cleanup. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8163 )

Change subject: endpoint identifiers: Some code cleanup.
......................................................................


Patch Set 1:

> Not sure if anything should be done about this but the functions
 > you modified could be merged into res_pjsip.so and so both modules
 > could share the code instead of duplicating.

I don't think we should get into the habit of throwing random routines into res_pjsip.so simply because it is a handy common module.


-- 
To view, visit https://gerrit.asterisk.org/8163
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86924c31db5bd225ca0c1219c761b668c6f91189
Gerrit-Change-Number: 8163
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sun, 04 Feb 2018 17:02:52 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180204/3107f2b0/attachment.html>