[Asterisk-code-review] manager.c: Fix potential memory leak and corruption. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8131 )

Change subject: manager.c: Fix potential memory leak and corruption.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8131/1/main/manager.c
File main/manager.c:

https://gerrit.asterisk.org/#/c/8131/1/main/manager.c@9509
PS1, Line 9509: 	ast_str_append(fields_string, 0,
> Shouldn't we `return ast_str_append(...)`?  That way we return error if ast
Just looked at the doxygen for these functions, apparently I meant:
return ast_str_append(...) >= 0 ? 0 : -1;



-- 
To view, visit https://gerrit.asterisk.org/8131
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92f36b855540743b208d76e274152ee2d758176d
Gerrit-Change-Number: 8131
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 01 Feb 2018 18:54:02 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180201/aee55a64/attachment.html>