[Asterisk-code-review] Fixed null string trailing after AsyncAGIEnd AMI event (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Feb 1 06:23:36 CST 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8047 )

Change subject: Fixed null string trailing after AsyncAGIEnd AMI event
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/8047/4//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/8047/4//COMMIT_MSG@9
PS4, Line 9: Removed creating json_null() object for NULL data.
This is no longer accurate.


https://gerrit.asterisk.org/#/c/8047/4/main/manager.c
File main/manager.c:

https://gerrit.asterisk.org/#/c/8047/4/main/manager.c@1811
PS4, Line 1811: 	}
The else should be on this line per coding guidelines.



-- 
To view, visit https://gerrit.asterisk.org/8047
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice58c16361f9d9e8648261c9ed5d6c8245fb0d8f
Gerrit-Change-Number: 8047
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 12:23:36 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180201/3908a71b/attachment.html>


More information about the asterisk-code-review mailing list