[Asterisk-code-review] app voicemail: Add Mailbox Aliases (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10799 )

Change subject: app_voicemail:  Add Mailbox Aliases
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10799/2/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/10799/2/apps/app_voicemail.c@13870
PS2, Line 13870: 		val = ast_variable_retrieve(cfg, "general", "aliasescontext");
Minor: How about 'aliases' or 'alias_context' or 'aliases_context?' If you don't already know what it says it takes a second to mentally parse it.



-- 
To view, visit https://gerrit.asterisk.org/10799
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I395b9205c91523a334fe971be0d1de4522067b04
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 16:55:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181218/de2c6d82/attachment.html>