[Asterisk-code-review] Revert "RTP: reset DTMF last seqno/timestamp on voice packet... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Tue Dec 11 09:44:25 CST 2018


Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10789 )

Change subject: Revert "RTP: reset DTMF last seqno/timestamp on voice packet with marker bit"
......................................................................


Patch Set 1:

Why revert?
What's wrong with my patch?
The reporter of ASTERISK-28200 did not provide any proves.

I think it may be silence suppression sets the marker bit.
If so, instead of revert we should improve my patch to reflect silence suppression behavior.


-- 
To view, visit https://gerrit.asterisk.org/10789
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If18ab1166db0d634ce8a099bd7460251e9c682e1
Gerrit-Change-Number: 10789
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 11 Dec 2018 15:44:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181211/f37bd77e/attachment.html>


More information about the asterisk-code-review mailing list