[Asterisk-code-review] Revert "RTP: reset DTMF last seqno/timestamp on voice packet... (asterisk[16])

George Joseph asteriskteam at digium.com
Tue Dec 11 08:28:19 CST 2018


Hello Friendly Automation, Joshua C. Colp, Alexei Gradinari,

I'd like you to do a code review. Please visit

    https://gerrit.asterisk.org/10787

to review the following change.


Change subject: Revert "RTP: reset DTMF last seqno/timestamp on voice packet with marker bit"
......................................................................

Revert "RTP: reset DTMF last seqno/timestamp on voice packet with marker bit"

This reverts commit 331c906c4811df17612efa5c31e19df7186b1c81.

Pending resolution of ASTERISK_28200

Change-Id: Ie7172707b603c1da3f200613bd4473335af75128
---
M res/res_rtp_asterisk.c
1 file changed, 0 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/87/10787/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index ff8e453..465f9bc 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -6438,16 +6438,6 @@
 	switch (ast_format_get_type(rtp->f.subclass.format)) {
 	case AST_MEDIA_TYPE_AUDIO:
 		rtp->f.frametype = AST_FRAME_VOICE;
-
-		/* The marker bit set on the voice packet indicates the start
-		 * of a new stream and a new time stamp. Need to reset the DTMF
-		 * last sequence number and the timestamp of the last END packet.
-		 */
-		if (mark) {
-			rtp->last_seqno = 0;
-			rtp->last_end_timestamp = 0;
-		}
-
 		break;
 	case AST_MEDIA_TYPE_VIDEO:
 		rtp->f.frametype = AST_FRAME_VIDEO;

-- 
To view, visit https://gerrit.asterisk.org/10787
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7172707b603c1da3f200613bd4473335af75128
Gerrit-Change-Number: 10787
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181211/14335165/attachment.html>


More information about the asterisk-code-review mailing list