[Asterisk-code-review] main/cdr: Fixed cdr start overwriting (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10747 )

Change subject: main/cdr: Fixed cdr start overwriting
......................................................................


Patch Set 3:

Hi Joshua, here's my understanding.


The problem cdr state flow is this.
None -> Single -> Dial -> DialPending -> Single -> Fianalized

And according the CDR description https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CDR+Specification

It should be into 2 CDRs
None -> Single -> Dial -> Finalized.
None -> Single -> Fianalized

or should be like this.
None -> Single -> Finalized.

But, because of the "DialPending" state, it was possible to go back to "Single" state.

I was wondering what is the "DialPedning" state, because it's not shown in the doc.
If I'm correct, it's very special state designed only for Stasis.
Anyways it allows to go to Single state with 'continue' ari action.

In this case, the cdr's start time must not be reset. Because it's not new cdr.
The "Single" state was designed for initiating CDR.
So, without initiating, it's working as it designed for.

I fixed code like this way(don't initiating).

Plus, here's my answers.

* this explicitly reset it before, so was that on purpose?
-> Yes, that was on pupose except this case.

* what was that scenario?
-> All the possible scenario for the go to Single(execute dialplan) from the DialPending state.

* was that correct
-> For this case, it was not correct.


-- 
To view, visit https://gerrit.asterisk.org/10747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc
Gerrit-Change-Number: 10747
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 23:17:10 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181206/07fda083/attachment.html>