[Asterisk-code-review] Fix deadlock handling subscribe req during res parking reload (asterisk[13])

[Giuseppe Sucameli]

Giuseppe Sucameli has posted comments on this change. ( https://gerrit.asterisk.org/10701 )

Change subject: Fix deadlock handling subscribe req during res_parking reload
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/10701/3/main/pbx.c
File main/pbx.c:

https://gerrit.asterisk.org/#/c/10701/3/main/pbx.c@3315
PS3, Line 3315: 	if (!hint->exten) {
> Is there a guarantee that this function will get called and thus this logic invoked? If there is the […]
I agree that the comment must be improved to better explain the lifecycle.

The function get called due to the call to publish_hint_change at the end of the ast_remove_hint function. BTW I'll look for any other paths.



-- 
To view, visit https://gerrit.asterisk.org/10701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b03c3455b3b12b6f83cea4cc34f4b4b20444f7e
Gerrit-Change-Number: 10701
Gerrit-PatchSet: 3
Gerrit-Owner: Giuseppe Sucameli <sucameli at netresults.it>
Gerrit-Reviewer: Giuseppe Sucameli <sucameli at netresults.it>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 12:18:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181206/fcd0ee65/attachment.html>