[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10704 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10704/1/include/asterisk/res_pjsip_session.h
File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/#/c/10704/1/include/asterisk/res_pjsip_session.h@588
PS1, Line 588: #define ast_sip_session_register_supplement(supplement) \
> I'm personally fine with it as that is such a narrow scenario, but others can chime in too. […]
This same thing is done in 13 - modules that call ast_sip_session_register_supplement and are compiled against 13.24.0 or 16.1.0 will not load under older versions.  Modules compiled against older versions will continue to work in newer versions.  This cannot be avoided if we want a central fix.  The only 100% forward & backward ABI compatible way to fix would be to manually add ast_module_shutdown_ref directly to every module which provides a session supplement.



-- 
To view, visit https://gerrit.asterisk.org/10704
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10704
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 15:29:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181203/fd45914a/attachment.html>