[Asterisk-code-review] pbx config.c: Fix reloading module if initially declined to ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9883 )

Change subject: pbx_config.c: Fix reloading module if initially declined to load
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/9883/7/pbx/pbx_config.c
File pbx/pbx_config.c:

https://gerrit.asterisk.org/#/c/9883/7/pbx/pbx_config.c@2048
PS7, Line 2048: 	if (!local_table)
              : 		local_table = ast_hashtab_create(17, ast_hashtab_compare_contexts, ast_hashtab_resize_java, ast_hashtab_newsize_java, ast_hashtab_hash_contexts, 0);
              : 
              : 	if (local_table == NULL) {
              : 		ast_hashtab_destroy(local_table, NULL);
              : 		ast_mutex_unlock(&reload_lock);
              : 		return AST_MODULE_LOAD_DECLINE;
              : 	}
The highlighted code should have just been:

if (!local_table) {
   local_table = ast_hashtab_create(...);
   if (!local_table) {
      ast_mutex_unlock(&reload_lock);
      return AST_MODULE_LOAD_DECLINE);
   }
}



-- 
To view, visit https://gerrit.asterisk.org/9883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00665106043b1be5148ffa7a477396038915854
Gerrit-Change-Number: 9883
Gerrit-PatchSet: 7
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 31 Aug 2018 18:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180831/314a2b54/attachment.html>