[Asterisk-code-review] Create --disable-binary-modules option. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10006 )

Change subject: Create --disable-binary-modules option.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10006/2/configure
File configure:

https://gerrit.asterisk.org/#/c/10006/2/configure@8921
PS2, Line 8921: PBX_NO_BINARY_MODULES=0
> Are you wanting me to have a default value PBX_BINARY_MODULES=1 and
 > have menuselect entries require `binary_modules` instead of
 > conflicting with `no_binary_modules`?  If so I can do that easily. 
 > If not please explain further.

No not necessarily.  It's just confusing to see references to "enable-binary-modules" when the option is actually "disable-binary-modules".

 > 
 > FWIW this option does something different than --disable-xmldocs or
 > --disable-asteriskssl.  Those options control the Makefile where
 > this option is used directly as a menuselect dependency.  So the
 > AC_SUBST variable here needs a 0 or 1 value, yes/no won't work.

Yep I understand that.  Can we not use the same plumbing though so we don't need to reference "enable-binary-modules"?



-- 
To view, visit https://gerrit.asterisk.org/10006
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1bd1c75a2e48f05b8b8a45b7a7a2d00a079166
Gerrit-Change-Number: 10006
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 28 Aug 2018 14:23:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180828/8256e84d/attachment.html>