[Asterisk-code-review] alembic: increase uri column size (asterisk[16])

George Joseph asteriskteam at digium.com
Tue Aug 28 09:17:32 CDT 2018


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/9994 )

Change subject: alembic: increase uri column size
......................................................................

alembic: increase uri column size

When mobile SIP clients register with Asterisk that use some sort of
push notifications, the URI can get quite lengthy due to the
additional push-service annotations (things like tokens, pn-type, etc.)
contained in it.

ASTERISK-28022 #close

Change-Id: I6c55013bafe79f7e7a1fb6722d2558f553709f2e
---
A contrib/ast-db-manage/config/versions/1d3ed26d9978_increase_uri_column_size.py
1 file changed, 22 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Matthew Fredrickson: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/contrib/ast-db-manage/config/versions/1d3ed26d9978_increase_uri_column_size.py b/contrib/ast-db-manage/config/versions/1d3ed26d9978_increase_uri_column_size.py
new file mode 100644
index 0000000..d00d0fa
--- /dev/null
+++ b/contrib/ast-db-manage/config/versions/1d3ed26d9978_increase_uri_column_size.py
@@ -0,0 +1,22 @@
+"""Increase uri column size
+
+Revision ID: 1d3ed26d9978
+Revises: 19b00bc19b7b
+Create Date: 2018-08-23 11:46:13.283801
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = '1d3ed26d9978'
+down_revision = '19b00bc19b7b'
+
+from alembic import op
+import sqlalchemy as sa
+
+
+def upgrade():
+    op.alter_column('ps_contacts', 'uri', type_=sa.String(511))
+
+
+def downgrade():
+    op.alter_column('ps_contacts', 'uri', type_=sa.String(255))

-- 
To view, visit https://gerrit.asterisk.org/9994
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c55013bafe79f7e7a1fb6722d2558f553709f2e
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180828/5e18b0cd/attachment-0001.html>


More information about the asterisk-code-review mailing list