[Asterisk-code-review] chan sip: remove unnecessary ast channel unlock(peer) as RA... (asterisk[15])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/9990 )

Change subject: chan_sip:  remove unnecessary ast_channel_unlock(peer) as RAII looks after it
......................................................................

chan_sip:  remove unnecessary ast_channel_unlock(peer) as RAII looks after it

Otherwise console output

        (get_refer_info): mutex 'peer' freed more times than we've locked!
        (get_refer_info): Error releasing mutex: Operation not permitted

    or
        (get_refer_info): attempted unlock mutex 'peer' without owning it!
        (__ast_read): 'peer' was locked here.
        ...dump_backtrace

        (get_refer_info): Error releasing mutex: Operation not permitted
        (__ast_read): mutex 'chan' freed more times than we've locked!

ASTERISK-28011 #close

Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893
---
M channels/chan_sip.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, approved
  George Joseph: Approved for Submit



diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index ad06422..de61343 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -18740,7 +18740,6 @@
 				S_OR(transferer->context, NULL));
 			pbx_builtin_setvar_helper(peer, "__SIPREFERREDBYHDR",
 				S_OR(p_referred_by, NULL));
-			ast_channel_unlock(peer);
 		}
 
 		owner_relock = sip_pvt_lock_full(transferer);

-- 
To view, visit https://gerrit.asterisk.org/9990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893
Gerrit-Change-Number: 9990
Gerrit-PatchSet: 1
Gerrit-Owner: Alec Davis <sivad.a at paradise.net.nz>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180824/939f6acf/attachment-0001.html>