[Asterisk-code-review] AMI: be less verbose when adding HTTP headers to AMI/HTTP me... (asterisk[13])

Jaco Kroon asteriskteam at digium.com
Wed Aug 22 15:03:01 CDT 2018


Hello Jenkins2, Corey Farrell, Sean Bright, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9970

to look at the new patch set (#3).

Change subject: AMI: be less verbose when adding HTTP headers to AMI/HTTP messages.
......................................................................

AMI: be less verbose when adding HTTP headers to AMI/HTTP messages.

All HTTP/AMI message headers are being sent to the verbose channel.
There are multiple places this is happening.  Consolidate the loop into
a function, and make this available to other modules that may have the
same requirements, and drop the debug/verbose message.

There is a continue on allocation failure (remnant from original loop)
that simply skips over memory allocations.  There is no feedback to the
caller about this which may be a problem.

Change-Id: Ic45e673fde05bd544be95ad5cdbc69518207c1a1
---
M include/asterisk/manager.h
M main/manager.c
2 files changed, 46 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/9970/3
-- 
To view, visit https://gerrit.asterisk.org/9970
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic45e673fde05bd544be95ad5cdbc69518207c1a1
Gerrit-Change-Number: 9970
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180822/3327b00f/attachment.html>


More information about the asterisk-code-review mailing list