[Asterisk-code-review] res pjsip transport websocket: Properly set src name for IPv6 (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/9984 )

Change subject: res_pjsip_transport_websocket: Properly set src_name for IPv6
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/9984/4/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

https://gerrit.asterisk.org/#/c/9984/4/res/res_pjsip_transport_websocket.c@296
PS4, Line 296: 	pj_ansi_strcpy(rdata->pkt_info.src_name, ast_sockaddr_stringify_addr(ast_websocket_remote_address(session)));
> PJPROJECT might also have a problem converting the IPv6 address to
 > a sockaddr unless there are []'s too.

As mentioned in the commit message, pjsip does not include the brackets in src_name within the built-in transports (i.e. sip_transport_udp.c)



-- 
To view, visit https://gerrit.asterisk.org/9984
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea9d289901b837512bee2ca2535e3dc14f04d77
Gerrit-Change-Number: 9984
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 18:56:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180822/4d1d680f/attachment.html>