[Asterisk-code-review] sample configs: noload res hep.so by default (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Wed Aug 22 13:05:52 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9992 )

Change subject: sample_configs: noload res_hep.so by default
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/9992/1/configs/basic-pbx/modules.conf
File configs/basic-pbx/modules.conf:

https://gerrit.asterisk.org/#/c/9992/1/configs/basic-pbx/modules.conf@114
PS1, Line 114: noload = res_hep.so
For completeness should also add

noload = res_hep_pjsip.so
noload = res_hep_rtcp.so


https://gerrit.asterisk.org/#/c/9992/1/configs/samples/modules.conf.sample
File configs/samples/modules.conf.sample:

https://gerrit.asterisk.org/#/c/9992/1/configs/samples/modules.conf.sample@40
PS1, Line 40: noload => res_hep.so
For completeness should also add

noload = res_hep_pjsip.so
noload = res_hep_rtcp.so

Also should separate from the chan_alsa.so..chan_console.so block as there is a comment talking about those modules and we don't want res_hep.so lumped with that comment.



-- 
To view, visit https://gerrit.asterisk.org/9992
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec150cf941634fabc72973e5bf1a965cb0ef9d0
Gerrit-Change-Number: 9992
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 18:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180822/ea09c9b9/attachment.html>


More information about the asterisk-code-review mailing list