[Asterisk-code-review] res parking: Increase size of parking space numbers (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/9933 )

Change subject: res_parking: Increase size of parking space numbers
......................................................................


Patch Set 2: Code-Review-1

I'm against this patch in general just because I feel that it is wholly unnecessary.

That being said - were it to be committed you should drop the typedef and just use int64_t or uint64_t (I don't know which one is more appropriate because I haven't looked that closely). Then you would also use PRId64 or PRIu64 instead of the _FORMAT #define you created.


-- 
To view, visit https://gerrit.asterisk.org/9933
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbeee7546d5ab3ea3ce29c68b4810eb4e51decad
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 2
Gerrit-Owner: Karl Brose <karlbrose at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 21 Aug 2018 20:11:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180821/490fb312/attachment.html>