[Asterisk-code-review] res pjsip transport websocket: Properly set src name for IPv6 (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Aug 21 15:08:15 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9984 )

Change subject: res_pjsip_transport_websocket: Properly set src_name for IPv6
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9984/3/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

https://gerrit.asterisk.org/#/c/9984/3/res/res_pjsip_transport_websocket.c@296
PS3, Line 296: 	pj_ansi_strcpy(rdata->pkt_info.src_name, ast_sockaddr_stringify_fmt(ast_websocket_remote_address(session), AST_SOCKADDR_STR_ADDR));
Use ast_sockaddr_stringify_addr() instead.  It does the exact same thing and is more readable.



-- 
To view, visit https://gerrit.asterisk.org/9984
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea9d289901b837512bee2ca2535e3dc14f04d77
Gerrit-Change-Number: 9984
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 21 Aug 2018 20:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180821/d3cdb799/attachment.html>


More information about the asterisk-code-review mailing list