[Asterisk-code-review] res sorcery realtime.c: Fix unqualified fetch warning. (asterisk[15])

George Joseph asteriskteam at digium.com
Mon Aug 20 11:31:31 CDT 2018


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/9955 )

Change subject: res_sorcery_realtime.c: Fix unqualified fetch warning.
......................................................................

res_sorcery_realtime.c: Fix unqualified fetch warning.

The allow_unqualified_fetch option for the sorcery realtime backend
blocked actually fetching all rows when the option is set to warn.

* Made issue a warning and actually do the request when
allow_unqualified_fetch=warn is set.

Change-Id: I74456c80a03a62dce66fc3dc3cb0cf2351ac4312
---
M res/res_sorcery_realtime.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/res/res_sorcery_realtime.c b/res/res_sorcery_realtime.c
index 1010340..31ba2f5 100644
--- a/res/res_sorcery_realtime.c
+++ b/res/res_sorcery_realtime.c
@@ -208,8 +208,7 @@
 			return;
 		}
 		if (config->fetch == UNQUALIFIED_FETCH_WARN) {
-			ast_log(LOG_WARNING, "Unqualified fetch attempted on %s\n", config->family);
-			return;
+			ast_log(LOG_WARNING, "Unqualified fetch requested on %s\n", config->family);
 		}
 
 		/* If no fields have been specified we want all rows, so trick realtime into doing it */

-- 
To view, visit https://gerrit.asterisk.org/9955
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I74456c80a03a62dce66fc3dc3cb0cf2351ac4312
Gerrit-Change-Number: 9955
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180820/2d9247cb/attachment.html>


More information about the asterisk-code-review mailing list