[Asterisk-code-review] AMI: be less verbose when adding headers to AMI messages. (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/9970 )

Change subject: AMI: be less verbose when adding headers to AMI messages.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/9970/1/main/manager.c
File main/manager.c:

https://gerrit.asterisk.org/#/c/9970/1/main/manager.c@7798
PS1, Line 7798: 	for (v = params; v && m.hdrcount < ARRAY_LEN(m.headers); v = v->next) {
              : 		hdrlen = strlen(v->name) + strlen(v->value) + 3;
              : 		m.headers[m.hdrcount] = ast_malloc(hdrlen);
              : 		if (!m.headers[m.hdrcount]) {
              : 			/* Allocation failure */
              : 			continue;
              : 		}
              : 		snprintf((char *) m.headers[m.hdrcount], hdrlen, "%s: %s", v->name, v->value);
              : 		ast_debug(1, "HTTP Manager add header %s\n", m.headers[m.hdrcount]);
              : 		++m.hdrcount;
              : 	}
These blocks are now identical (except for the debug level) so probably better to extract into a separate function.


https://gerrit.asterisk.org/#/c/9970/1/main/manager.c@7823
PS1, Line 7823: 	/* Free request headers. */
              : 	for (idx = 0; idx < m.hdrcount; ++idx) {
              : 		ast_free((void *) m.headers[idx]);
              : 		m.headers[idx] = NULL;
              : 	}
Same here.



-- 
To view, visit https://gerrit.asterisk.org/9970
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45e673fde05bd544be95ad5cdbc69518207c1a1
Gerrit-Change-Number: 9970
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 20 Aug 2018 13:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180820/d2322fb2/attachment-0001.html>