[Asterisk-code-review] pbx config.c: Some modules not be loaded if they initially d... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9883 )

Change subject: pbx_config.c: Some modules not be loaded if they initially decline to load
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/9883/5//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/9883/5//COMMIT_MSG@7
PS5, Line 7: pbx_config.c: Some modules not be loaded if they initially decline to load
Change to:

pbx_config.c: Fix reloading module if initially declined to load.


https://gerrit.asterisk.org/#/c/9883/5//COMMIT_MSG@9
PS5, Line 9: Added exit if extensions.conf file not available
           : on loading pbx_config
This statement is not true and should be removed from the commit message.  The second part of the sentence is what was done in the patch.

The commit message is not intended to be a history of the patch itself as that is part of what Gerrit does in the review process.  The commit message is to describe the problem the patch is fixing and an overview of the fix.



-- 
To view, visit https://gerrit.asterisk.org/9883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00665106043b1be5148ffa7a477396038915854
Gerrit-Change-Number: 9883
Gerrit-PatchSet: 5
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 17 Aug 2018 23:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180817/a7ff5914/attachment.html>