[Asterisk-code-review] CI: Disable res odbc if REF DEBUG is requested. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Fri Aug 17 06:16:14 CDT 2018


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/9878 )

Change subject: CI: Disable res_odbc if REF_DEBUG is requested.
......................................................................

CI: Disable res_odbc if REF_DEBUG is requested.

This is for 13/15 only, res_odbc never unloads so it is impossible to do
REF_DEBUG testing with that module.

Change-Id: I2c1e32b80564e8fb08b6b5900ede6b5d304ebd10
---
M tests/CI/buildAsterisk.sh
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/tests/CI/buildAsterisk.sh b/tests/CI/buildAsterisk.sh
index 683b4bb..b3266bd 100755
--- a/tests/CI/buildAsterisk.sh
+++ b/tests/CI/buildAsterisk.sh
@@ -113,6 +113,13 @@
 	mod_disables+=" res_ael_share res_calendar res_config_ldap res_config_pgsql res_corosync"
 	mod_disables+=" res_http_post res_pktccops res_rtp_multicast res_snmp res_xmpp"
 fi
+if [ $REF_DEBUG -eq 1 ] ; then
+	# res_odbc does not unload at shutdown, including it with REF_DEBUG testing would cause
+	# every test to fail due to that leak.
+	# Note: --ref-debug and --realtime cannot be used together in this version of Asterisk.
+	# To test for reference leaks with realtime usage you must test against Asterisk 16+.
+	mod_disables+=" res_odbc"
+fi
 [ "$BRANCH_NAME" == "master" ] && mod_disables+=" codec_opus codec_silk codec_g729a codec_siren7 codec_siren14"
 runner menuselect/menuselect `gen_mods disable $mod_disables` menuselect.makeopts
 

-- 
To view, visit https://gerrit.asterisk.org/9878
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c1e32b80564e8fb08b6b5900ede6b5d304ebd10
Gerrit-Change-Number: 9878
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180817/3cedb152/attachment.html>


More information about the asterisk-code-review mailing list