[Asterisk-code-review] main/channel.c: continue scheduling timer when channel emula... (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9894 )

Change subject: main/channel.c: continue scheduling timer when channel emulate ring (ari)
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9894/1/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/9894/1/main/channel.c@4135
PS1, Line 4135: 			f = &ast_null_frame;
This change is incorrect. RTCP frames are now raised so that things (such as ConfBridge) can act on the data they contain. It is likely, instead, that code elsewhere is incorrectly stopping things when an RTCP frame comes up and should actually ignore it there instead.



-- 
To view, visit https://gerrit.asterisk.org/9894
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4a4bc515b040a78f5012c9046a8aa9a3eb4d62
Gerrit-Change-Number: 9894
Gerrit-PatchSet: 1
Gerrit-Owner: Hajek Michal <michal.hajek at daktela.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 11:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180816/5551a6cb/attachment-0001.html>