[Asterisk-code-review] res pjsip: Fix mwi subscribe replaces unsolicited type mismatch (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9841 )

Change subject: res_pjsip: Fix mwi_subscribe_replaces_unsolicited type mismatch
......................................................................


Patch Set 3: Code-Review-1

> > > I have a thought that could avoid losing data. You could create
 > a
 > > > new column, massage the data across to this new column, drop
 > the
 > > > old column and rename it. This appears to be possible based on
 > a
 > > > quick google, but I don't know level of effort. Just my 2¢
 > >
 > > I cannot say about level of effort either as this is Alembic and
 > we
 > > aren't that database knowledgeable.  Doing it may be very
 > database
 > > specific.  Alembic is supposed to hide database specific stuff
 > but
 > > it frequently does not.
 > >
 > > The loosing data part is why the already released branch patches
 > > were abandoned.  This is a breaking change to eliminate a type
 > > mismatch and not really necessary on the released branches.
 > 
 > Fine with me, just throwing out another option. God speed.

I think this is a large enough barrier to upgrade that warrants spending more time on.  Alembic does have the capability to do the conversion.


-- 
To view, visit https://gerrit.asterisk.org/9841
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccafdd0552ea8aaed647620fb14499f1bf341843
Gerrit-Change-Number: 9841
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 14 Aug 2018 12:02:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180814/d3ec5575/attachment.html>