[Asterisk-code-review] testsuite: Transport tests (testsuite[15])

Jenkins2 asteriskteam at digium.com
Wed Aug 8 04:24:15 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/9837 )

Change subject: testsuite: Transport tests
......................................................................

testsuite: Transport tests

Realtime had a problem with the mwi_subscribe_replaces_unsolicited option
because Alembic described the option's column one way and Asterisk output
it another way.  The thing is, the tests that set the option are not
testing nor needing the option's functionality.

* Remove listing mwi_subscribe_replaces_unsolicited when we are setting it
to the default value and we are not testing nor needing that functionality
anyway.

ASTERISK-27988

Change-Id: I78db223719eb3e6ba690747acd9f9a5ec96636e5
---
M tests/channels/pjsip/transport/reuse/notify/configs/ast1/pjsip.conf
M tests/channels/pjsip/transport/symmetric/notify/configs/ast1/pjsip.conf
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/channels/pjsip/transport/reuse/notify/configs/ast1/pjsip.conf b/tests/channels/pjsip/transport/reuse/notify/configs/ast1/pjsip.conf
index e4e1673..eb2f342 100644
--- a/tests/channels/pjsip/transport/reuse/notify/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/transport/reuse/notify/configs/ast1/pjsip.conf
@@ -19,7 +19,6 @@
 aors=alice
 auth=alice
 mailboxes=1000 at default
-mwi_subscribe_replaces_unsolicited=0
 rewrite_contact=yes
 
 [alice]
diff --git a/tests/channels/pjsip/transport/symmetric/notify/configs/ast1/pjsip.conf b/tests/channels/pjsip/transport/symmetric/notify/configs/ast1/pjsip.conf
index a7bf340..3f4bd14 100644
--- a/tests/channels/pjsip/transport/symmetric/notify/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/transport/symmetric/notify/configs/ast1/pjsip.conf
@@ -21,7 +21,6 @@
 aors=alice
 auth=alice
 mailboxes=1000 at default
-mwi_subscribe_replaces_unsolicited=0
 
 [alice]
 type=aor

-- 
To view, visit https://gerrit.asterisk.org/9837
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I78db223719eb3e6ba690747acd9f9a5ec96636e5
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180808/7583ada8/attachment-0001.html>


More information about the asterisk-code-review mailing list