[Asterisk-code-review] res pjsip: Fix mwi subscribe replaces unsolicited type mismatch (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9840 )

Change subject: res_pjsip: Fix mwi_subscribe_replaces_unsolicited type mismatch
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/9840/1/contrib/ast-db-manage/config/versions/fe6592859b85_fix_mwi_subscribe_replaces_.py
File contrib/ast-db-manage/config/versions/fe6592859b85_fix_mwi_subscribe_replaces_.py:

https://gerrit.asterisk.org/#/c/9840/1/contrib/ast-db-manage/config/versions/fe6592859b85_fix_mwi_subscribe_replaces_.py@29
PS1, Line 29:     op.drop_column('ps_endpoints', 'mwi_subscribe_replaces_unsolicited')
            :     op.add_column('ps_endpoints', sa.Column('mwi_subscribe_replaces_unsolicited', yesno_values))
Is there no way to preserve the data in some way?

Just blasting away any existing seems concerning, at the very least without a notice somewhere.



-- 
To view, visit https://gerrit.asterisk.org/9840
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccafdd0552ea8aaed647620fb14499f1bf341843
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 09:23:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180808/93474826/attachment.html>