[Asterisk-code-review] res pjsip/rtp: No joint capabilities between streams. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9832 )

Change subject: res_pjsip/rtp: No joint capabilities between streams.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/9832/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/9832/1/res/res_pjsip_session.c@942
PS1, Line 942: 		/* The stream state will have already been set to removed when either we
             : 		 * negotiate the incoming SDP stream or when we produce our own local SDP.
             : 		 * This can occur if an internal thing has requested it to be removed, or if
             : 		 * we remove it as a result of the stream limit being reached.
             : 		 */
This comment is no longer true/accurate based on the above added code.


https://gerrit.asterisk.org/#/c/9832/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/9832/1/res/res_rtp_asterisk.c@5805
PS1, Line 5805: 			if (ssrc != rtp->themssrc && use_packet_source && ssrc != 1) {
There should be a comment about what '1' means and why it occurs.



-- 
To view, visit https://gerrit.asterisk.org/9832
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e7c6f101bc119549eeca406b5bcd25ad8ebc5e
Gerrit-Change-Number: 9832
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 16:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180807/4c164147/attachment.html>