[Asterisk-code-review] dialplan functions: wrong srtp use status report of a dialpl... (asterisk[16])

Richard Mudgett asteriskteam at digium.com
Fri Aug 3 13:38:53 CDT 2018


Hello Salah Ahmed, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9811

to look at the new patch set (#2).

Change subject: dialplan_functions: wrong srtp use status report of a dialplan function
......................................................................

dialplan_functions: wrong srtp use status report of a dialplan function

If asterisk offer an endpoint with SRTP and that endpoint respond
with non srtp, in that case channel(rtp,secure,audio) reply wrong
status.

Why delete flag AST_SRTP_CRYPTO_OFFER_OK while check identical remote_key:
Currently this flag has being set redundantly. In either case identical
or different remote_key this flag has being set. So if we
don't set it while we receive identical remote_key or non SRTP SDP
response then we can take decision of srtp use by using that flag.

ASTERISK-27999

Change-Id: I29dc2843cf4e5ae2604301cb4ff258f1822dc2d7
---
M channels/pjsip/dialplan_functions.c
M res/res_srtp.c
2 files changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/9811/2
-- 
To view, visit https://gerrit.asterisk.org/9811
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d10e8b82e5eed845cca9921f78e4e7530f544ee
Gerrit-Change-Number: 9811
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Salah Ahmed <txrubel at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180803/20a481c4/attachment.html>


More information about the asterisk-code-review mailing list