[Asterisk-code-review] res pjsip registrar: Improve performance on inbound handling. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9802 )

Change subject: res_pjsip_registrar: Improve performance on inbound handling.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/9802/2/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

https://gerrit.asterisk.org/#/c/9802/2/res/res_pjsip_registrar.c@662
PS2, Line 662: 		contact = ao2_callback(contacts, OBJ_UNLINK, registrar_find_contact, &details);
Since this no longer finds permanent contacts, if someone REGISTER's one we'll create a duplicate contact and put it into the contacts container.  I'm not sure what happened before in this case.  Likely the same thing as now.  We'll have duplicate contacts one permanent and one dynamic.



-- 
To view, visit https://gerrit.asterisk.org/9802
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a78b2d46f9a2045dbbff1a3fd6dba84b612b3cb
Gerrit-Change-Number: 9802
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 15:58:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180803/2aeed790/attachment.html>