[Asterisk-code-review] pjsip channel test condition: Fix flake8 and pep8 errors. (testsuite[master])

Jenkins2 asteriskteam at digium.com
Mon Apr 30 07:41:47 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8867 )

Change subject: pjsip_channel_test_condition: Fix flake8 and pep8 errors.
......................................................................

pjsip_channel_test_condition: Fix flake8 and pep8 errors.

* End header comment with ''' (single quotes) to match start of header
  comment.
* Address 'E251 unexpected spaces around keyword / parameter equals'
  pep8 error.
* Remove unused shebang (this module is not executable).

Change-Id: I887d0427089878f4f2fd62b817b23b9288253958
---
M lib/python/asterisk/pjsip_channel_test_condition.py
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/lib/python/asterisk/pjsip_channel_test_condition.py b/lib/python/asterisk/pjsip_channel_test_condition.py
index 2956bef..a30c8cc 100644
--- a/lib/python/asterisk/pjsip_channel_test_condition.py
+++ b/lib/python/asterisk/pjsip_channel_test_condition.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 '''
 Copyright (C) 2018, Digium, Inc.
 Torrey Searle  <tsearle at gmail.com>
@@ -7,7 +6,7 @@
 
 This program is free software, distributed under the terms of
 the GNU General Public License Version 2.
-"""
+'''
 
 from twisted.internet import defer
 from test_conditions import TestCondition
@@ -30,7 +29,7 @@
         if ('allowedchannels' in test_config.config):
             self.allowed_channels = test_config.config['allowedchannels']
 
-    def evaluate(self, related_test_condition = None):
+    def evaluate(self, related_test_condition=None):
         """Evaluate the test condition"""
 
         def __channel_callback(result):

-- 
To view, visit https://gerrit.asterisk.org/8867
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I887d0427089878f4f2fd62b817b23b9288253958
Gerrit-Change-Number: 8867
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180430/07778314/attachment.html>


More information about the asterisk-code-review mailing list