[Asterisk-code-review] sip to pjsip: Enable python3 compatibility. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8805 )

Change subject: sip_to_pjsip: Enable python3 compatibility.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/8805/1/contrib/scripts/sip_to_pjsip/sqlconfigparser.py
File contrib/scripts/sip_to_pjsip/sqlconfigparser.py:

https://gerrit.asterisk.org/#/c/8805/1/contrib/scripts/sip_to_pjsip/sqlconfigparser.py@3
PS1, Line 3: try:
> Sure you can get a comment. However, I have no idea what I should put into 
I'm interested in knowing why we're adding pymysql as the default option to provide mysql connectivity.  Is this module better than MySQLdb for some reason, is MySQLdb deprecated, or is MySQLdb broken in python3?



-- 
To view, visit https://gerrit.asterisk.org/8805
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59cc6b52a1a89777eebcf25b3023bdf93babf835
Gerrit-Change-Number: 8805
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 19:00:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180426/b6ff45f0/attachment.html>