[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8794 )

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8794/1/include/asterisk/channel.h
File include/asterisk/channel.h:

https://gerrit.asterisk.org/#/c/8794/1/include/asterisk/channel.h@948
PS1, Line 948: 	AST_CHAN_TP_SEND_TEXT_DATA = (1 << 3),
> Why do we need to add an additional property for this?
Because the patch adds a new technology callback to the structure.  Precompiled channel modules will not have that callback in the structure and thus effectively have garbage there.  This is a way to add the callback to the structure and not require third-party modules to be recompiled due to the ABI change.



-- 
To view, visit https://gerrit.asterisk.org/8794
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 8794
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 18:47:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180426/2877fb82/attachment.html>