[Asterisk-code-review] translate: generic plc not filled in after translation (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8820 )

Change subject: translate: generic plc not filled in after translation
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8820/1/main/translate.c
File main/translate.c:

https://gerrit.asterisk.org/#/c/8820/1/main/translate.c@543
PS1, Line 543: 	res.subclass.format = ast_format_cache_get_slin_by_rate(8000); /* ref bumped on dup */
> I don't understand the question. We only try to fill with generic plc on fr
I know, but there's code in ast_channel_make_compatible_helper which seems to imply that generic plc is for signed linear at other sample rates as well.



-- 
To view, visit https://gerrit.asterisk.org/8820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I133d084da87adef913bf2ecc9c9240e3eaf4f40a
Gerrit-Change-Number: 8820
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 24 Apr 2018 19:42:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180424/1284a15a/attachment.html>