[Asterisk-code-review] pjsip channel: Use specified media port (testsuite[13])

Kevin Harwell asteriskteam at digium.com
Tue Apr 24 14:15:53 CDT 2018


Hello Corey Farrell, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8857

to look at the new patch set (#2).

Change subject: pjsip_channel: Use specified media port
......................................................................

pjsip_channel: Use specified media port

This test took advantage of the fact that SIPp defaults the media port to 6000,
which it then checked against for the test. However, a recent patch made it so
tests using the SIPp 'media_port' option would get an available random port
instead.

This patch no longer uses the 'media_port' option, but instead uses a hard
coded value for the media port in the SDP. A number was chosen which hopefully
makes port collisions highly unlikely.

Change-Id: Id7f82d8245401659d269e6ba084c2ad05aee068d
---
M tests/channels/pjsip/dialplan_functions/pjsip_channel/configs/ast1/extensions.conf
M tests/channels/pjsip/dialplan_functions/pjsip_channel/test-config.yaml
2 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/57/8857/2
-- 
To view, visit https://gerrit.asterisk.org/8857
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7f82d8245401659d269e6ba084c2ad05aee068d
Gerrit-Change-Number: 8857
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180424/3f860e0e/attachment.html>


More information about the asterisk-code-review mailing list