[Asterisk-code-review] Begin work on python3 compatability. (testsuite[master])

Corey Farrell asteriskteam at digium.com
Fri Apr 20 17:35:01 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8854 )

Change subject: Begin work on python3 compatability.
......................................................................


Patch Set 1:

1) This will be rebased once 8691 and 8829 are merged.
2) The Jenkins failure will be resolved by merge of 8830.

This is being posted now in the hopes that someone with spare system resources can run the full testsuite with python2.  I've spot-checked a couple of tests, they still work but I would be surprised if nothing is broken by this.

./self_test can be run to execute the unit tests (they all pass for me under python2 and python3).  Note that test_sip_dialog_test_condition is disabled not due to the python2 conversion, sip_dialog_test_condition is already broken in the current code.  The test was renamed with a .txt extension to suppress pep8 warnings from that file.  lib/python/asterisk/self_test/*.py passes pep8 and flake8.

The hope is that this can be merged pretty much as is once it's rebased and verified python2 is not broken, with additional python3 issues to be addressed in follow-up reviews.


-- 
To view, visit https://gerrit.asterisk.org/8854
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76c2d3e11e4ab4552d0df7841287c8bb2de7918
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 20 Apr 2018 22:35:01 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180420/811527a3/attachment.html>


More information about the asterisk-code-review mailing list