[Asterisk-code-review] sipp, test suite utils: Default media port to an unused port (testsuite[13])

Kevin Harwell asteriskteam at digium.com
Thu Apr 19 17:28:21 CDT 2018


Hello Benjamin Keith Ford, Jenkins2, Corey Farrell, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8689

to look at the new patch set (#7).

Change subject: sipp, test_suite_utils: Default media port to an unused port
......................................................................

sipp, test_suite_utils: Default media port to an unused port

SIPp correctly chooses an available port for audio, but unfortunately it then
attempts to bind to the audio port + n for things like rtcp and video without
first checking if those other ports are unused:

https://github.com/SIPp/sipp/issues/276

This patch makes it so all ports needed by the scenario are available. It does
this by retrieving and checking for an unused port plus 'n' ports from the OS.
If the ports are available then the primary port is passed to the scenario using
the '-mp' option.

Change-Id: I3da461123afc30e1f5ca12e65d289eaa42d6de00
---
A lib/python/asterisk/self_test/test_utils_socket.py
M lib/python/asterisk/sipp.py
A lib/python/asterisk/utils_socket.py
3 files changed, 502 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/89/8689/7
-- 
To view, visit https://gerrit.asterisk.org/8689
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3da461123afc30e1f5ca12e65d289eaa42d6de00
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 7
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180419/99413f38/attachment.html>


More information about the asterisk-code-review mailing list