[Asterisk-code-review] bridge softmix: Fix some REMB bugs. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8834 )

Change subject: bridge_softmix: Fix some REMB bugs.
......................................................................


Patch Set 1:

(2 comments)

Some minor things

https://gerrit.asterisk.org/#/c/8834/1/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/8834/1/bridges/bridge_softmix.c@1338
PS1, Line 1338: 	 * still prefers it be accurate instead of lying.
s/it be/it to be/


https://gerrit.asterisk.org/#/c/8834/1/bridges/bridge_softmix.c@2087
PS1, Line 2087: 	AST_VECTOR_RESET(&softmix_data->remb_collectors, ao2_cleanup);
              : 	AST_VECTOR_DEFAULT(&softmix_data->remb_collectors, AST_VECTOR_MAX_SIZE(&softmix_data->remb_collectors), NULL);
This is kind of inefficient and it changes the number of elements in the vector.  Why not:

int idx;

for (idx = 0; idx < AST_VECTOR_SIZE(&softmix_data->remb_collectors); ++idx) {
   ao2_cleanup(AST_VECTOR_GET(&softmix_data->remb_collectors, idx));
   AST_VECTOR_REPLACE(&softmix_data->remb_collectors, idx, NULL);
}



-- 
To view, visit https://gerrit.asterisk.org/8834
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9dc9c150043890ee7ff85e9cdec007f1a77fcfd
Gerrit-Change-Number: 8834
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 19:29:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180419/5b3d54c3/attachment.html>