[Asterisk-code-review] sip to pjsip: Enable python3 compatibility. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8805 )

Change subject: sip_to_pjsip: Enable python3 compatibility.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/8805/1/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py
File contrib/scripts/sip_to_pjsip/sip_to_pjsip.py:

https://gerrit.asterisk.org/#/c/8805/1/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py@169
PS1, Line 169:            return
> Shouldn't this indentation be lined up with 2 lines above?
No, because the line above has one space too much. Therefore, this is a different issue. However, you are right because this line here has only 7 spaces also it should have 8. This was not bailed by python3 or pyflakes3 because they are just about \t versus spaces. Anyway, I fixed both of them now.


https://gerrit.asterisk.org/#/c/8805/1/contrib/scripts/sip_to_pjsip/sqlconfigparser.py
File contrib/scripts/sip_to_pjsip/sqlconfigparser.py:

https://gerrit.asterisk.org/#/c/8805/1/contrib/scripts/sip_to_pjsip/sqlconfigparser.py@3
PS1, Line 3: try:
> Can we get a comment about this try/except block?
Sure you can get a comment. However, I have no idea what I should put into that. Please, give an example and/or as the question you (or somebody else might) have.



-- 
To view, visit https://gerrit.asterisk.org/8805
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59cc6b52a1a89777eebcf25b3023bdf93babf835
Gerrit-Change-Number: 8805
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 07:34:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180419/b8eff454/attachment.html>