[Asterisk-code-review] BuildSystem: Go for Python 2 explicitly, because that is cur... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8673 )

Change subject: BuildSystem: Go for Python 2 explicitly, because that is currently needed.
......................................................................


Patch Set 1:

> What exactly is blocking this?
 > Gerrit 8646 is far away from adding Python 3 support, see the PJSUA
 > part. Even if it does, the tool Python must be found differently.
 > For example, Ubuntu 18.04 LTS comes with Python 3 on default, but
 > does not have a ‘python’ anymore; except you install Python 2.

8646 makes the build system completely compatible with python2 and python3 tools which are not used to build the PJSUA component (see below for comments about PYTHONDEV).  The python tool detected by configure.ac is only used by 'make full' and 'make ari-stubs'.  It would be nice if you could give 8646 a review as it actually fixes the issue with the current version of python (3.x).  We should not go back and forth with the configure script, get it right the first time.  IMO the order of preference for python tools should be: python, python3, python2, python3.6, python2.7.  This will make us use the default per OS (/usr/bin/python), or if none is default it will try python3 (current) followed by python2 (legacy).

As for moving forward with PYTHONDEV v3, see ASTERISK-27787.  This includes patches that add pjsua2 (compatible with py2 and py3) but for this to be useful the testsuite will have to switch from pjsua to pjsua2 python modules (they're not source compatible).  So I have no problem with your PYTHONDEV changes as nobody has started work on using pjsua2.  But this has nothing to do with what version /usr/bin/python gives us as we do not use 'python setup.py' to build the pjsua python bindings.


-- 
To view, visit https://gerrit.asterisk.org/8673
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e694dc7e92510dc26b15895b55f78f67146b2c
Gerrit-Change-Number: 8673
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 18 Apr 2018 13:53:42 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180418/9a01cb9c/attachment.html>